Skip to content

Update github handle from AdamHarries to AdamBrouwersHarries#5014

Merged
AdamBrouwersHarries merged 2 commits into
firefox-devtools:mainfrom
AdamBrouwersHarries:adam-icon
May 31, 2024
Merged

Update github handle from AdamHarries to AdamBrouwersHarries#5014
AdamBrouwersHarries merged 2 commits into
firefox-devtools:mainfrom
AdamBrouwersHarries:adam-icon

Conversation

@AdamBrouwersHarries

Copy link
Copy Markdown
Contributor

I changed my github username, and now none of the links work, and my avatar is broken, in CONTRIBUTING.md. This PR updates my github username in CONTRIBUTING.md.

@canova

canova commented May 30, 2024

Copy link
Copy Markdown
Member

Could you run yarn prettier-fix to fix the prettier warnings and update the PR?
We also have a pre-push hook that checks these before pushing, so you can catch these earlier. You might need to install the dependencies with yarn or yarn install before though.

@AdamBrouwersHarries

Copy link
Copy Markdown
Contributor Author

We also have a pre-push hook that checks these before pushing, so you can catch these earlier.

It turns out I didn't have yarn installed (which was a surprise), so the pre-push hooks didn't run. Fixed now though!

@codecov

codecov Bot commented May 31, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.48%. Comparing base (5ac4665) to head (b382cc1).

Current head b382cc1 differs from pull request most recent head 920ef03

Please upload reports for the commit 920ef03 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5014   +/-   ##
=======================================
  Coverage   88.48%   88.48%           
=======================================
  Files         304      304           
  Lines       27393    27393           
  Branches     7400     7400           
=======================================
  Hits        24240    24240           
  Misses       2931     2931           
  Partials      222      222           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@canova canova left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AdamBrouwersHarries AdamBrouwersHarries merged commit 5d3ecae into firefox-devtools:main May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants